Skip to content

TEST: Adding a test case for multiple captioned figures#373

Merged
bsipocz merged 7 commits intomasterfrom
test-code-figures
Jun 3, 2025
Merged

TEST: Adding a test case for multiple captioned figures#373
bsipocz merged 7 commits intomasterfrom
test-code-figures

Conversation

@mmcky
Copy link
Copy Markdown
Member

@mmcky mmcky commented Nov 12, 2021

This PR adds a test case test_metadata_multiple_images

There is an issue when using more than one captioned figure when adding render metadata to figures produced by code.

This is a test case for: #374

@agoose77 agoose77 self-requested a review September 18, 2023 09:06
@agoose77 agoose77 closed this Sep 18, 2023
@agoose77 agoose77 reopened this Sep 18, 2023
@bsipocz bsipocz added the testing Additional testing to add label Jun 3, 2025
Copy link
Copy Markdown
Member

@bsipocz bsipocz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it never hurts to have more tests. Thanks!

@bsipocz bsipocz merged commit 201a48c into master Jun 3, 2025
15 checks passed
@bsipocz bsipocz deleted the test-code-figures branch June 3, 2025 02:37
@choldgraf
Copy link
Copy Markdown
Member

Congratulations on merging a 4 year old PR 🙂

@bsipocz
Copy link
Copy Markdown
Member

bsipocz commented Jun 3, 2025

Congratulations on merging a 4 year old PR 🙂

yeap, with this I think I cleared everything that could be merged, the rest of them will need some work/or get closed/or get re-reviewed/approved by someone else.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

testing Additional testing to add

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants