Skip to content

refactor: add new logger without a global state#1385

Merged
mrexox merged 20 commits into
evilmartians:masterfrom
mrexox:refactor/add-new-logger-without-a-global-state
May 18, 2026
Merged

refactor: add new logger without a global state#1385
mrexox merged 20 commits into
evilmartians:masterfrom
mrexox:refactor/add-new-logger-without-a-global-state

Conversation

@mrexox

@mrexox mrexox commented Apr 10, 2026

Copy link
Copy Markdown
Member

Context

Current internal/log implementation is kinda mess. Need to change the app to have injectable logger instead of a global logger + state and colors management.

Also move all printing-related logic into the logger package.

Changes

  • Add a logger.Logger type
  • Dynamically detect colors on/off based on ENV variables
  • Upgrade lipgloss package
  • Drop old log package and replace all the calls with logger.Logger
  • Add (and fix) tests
  • Final cleanup

@mrexox mrexox force-pushed the refactor/add-new-logger-without-a-global-state branch from aee141d to 3cb55a4 Compare May 4, 2026 07:24
@mrexox mrexox force-pushed the refactor/add-new-logger-without-a-global-state branch from e106556 to be6ba4a Compare May 15, 2026 10:30
@mrexox mrexox marked this pull request as ready for review May 17, 2026 09:03
@mrexox mrexox force-pushed the refactor/add-new-logger-without-a-global-state branch from 7999fd8 to 508fe6c Compare May 17, 2026 12:46
@mrexox mrexox force-pushed the refactor/add-new-logger-without-a-global-state branch from 508fe6c to f80c03b Compare May 17, 2026 13:03
@mrexox mrexox merged commit eb1064d into evilmartians:master May 18, 2026
12 of 14 checks passed
@mrexox mrexox deleted the refactor/add-new-logger-without-a-global-state branch May 18, 2026 12:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant