Merged
Conversation
We are using `%s` but the input is not a string. This can result in bad error messages
Owner
|
This is using %v so that the output contains quotes, as that's how fmt handles string inputs. |
Contributor
Author
|
I posted a link to a go playground example tl;dr, for a non-string input like |
Owner
|
Oh I'm sorry, I misread this entirely. |
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We are using
%sbut the input is not a string. This can result in bad error messages, for example https://go.dev/play/p/NoimdDgOdDR