refactor(beacon-chain): potential race to write callbacks#3
Merged
refactor(beacon-chain): potential race to write callbacks#3
Conversation
Savid
approved these changes
Feb 7, 2025
samcm
approved these changes
Feb 9, 2025
test(beacon_chain): add tests for concurrent stop and nil wallclock scenarios Adds a `Stop` method to the `EthereumBeaconChain` to allow for graceful shutdown of the background goroutines. This prevents goroutine leaks when the beacon chain is no longer needed. Adds tests to ensure that calling `Stop` concurrently with callback registration does not cause a race condition or panic. Adds a test to specifically address a production issue where calling `OnEpochChanged` on a nil `EthereumBeaconChain` receiver caused a panic. This test simulates the scenario where the wallclock becomes nil and verifies that the expected panic occurs, highlighting the need for nil checks before calling methods on the wallclock.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
tldr; running
go testwith-raceis picking-up that this insn't thread-safe.I'm writing some unrelated e2e tests for
contributoorand was getting some unusual failures stemming from this pkg when running tests with-race.This is not a problem for production right now, given how we typically use this pkg during initialization
Initially I thought this was related to our multi-beacon-node changes in
contributoor:MetadataServicecreates its ownethwallclockinstanceIf you run
go test -v -race ./...onmasterof this repo, you'll see the race's/failures in question.I'd love to keep using
-raceacrosscontributoorand other pkgs, so hence this PR.