cmd/utils: fix handling of boolean flags when they are set to false#33338
Merged
jwasinger merged 1 commit intoethereum:masterfrom Dec 2, 2025
Merged
cmd/utils: fix handling of boolean flags when they are set to false#33338jwasinger merged 1 commit intoethereum:masterfrom
jwasinger merged 1 commit intoethereum:masterfrom
Conversation
Member
|
Hi, thanks a lot for your contribution! 🙏 We really appreciate the effort and encourage you to keep contributing, but for now we need to focus our limited review bandwidth on feature work, bug fixes, and protocol changes. Thanks for understanding! |
Contributor
|
This is worth merging. |
jwasinger
approved these changes
Dec 1, 2025
fjl
approved these changes
Dec 2, 2025
wit765
added a commit
to wit765/XDPoSChain
that referenced
this pull request
Dec 10, 2025
AnilChinchawale
pushed a commit
to XinFinOrg/XDPoSChain
that referenced
this pull request
Dec 12, 2025
weiihann
pushed a commit
to weiihann/go-ethereum
that referenced
this pull request
Jan 14, 2026
…thereum#33338) geth --nodiscover=false may result in ctx.IsSet(NoDiscoverFlag.Name) is true, but cfg. NoDiscovery should be false, not true.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
geth --nodiscover=false
may result in ctx.IsSet(NoDiscoverFlag.Name) is true, but cfg. NoDiscovery should be false, not true.