[3.5] backport etcdutl memory allocation issue#17977
Merged
serathius merged 2 commits intoetcd-io:release-3.5from May 10, 2024
Merged
Conversation
Accept a third argument for NewDefaultBackend for overrides to the BackendConfig. Add a new function, WithMmapSize, which modifies the backend config to provide a custom InitiamMmapSize. Backports commit: d69adf4 / PR: etcd-io#17277 Signed-off-by: Ivan Valdes <ivan@vald.es>
When running the snapshot command, allow receiving an initial memory map allocation for the database, avoiding future memory allocation issues. Backports commit: be28833 / PR: etcd-io#17277 Co-authored-by: Fatih USTA <fatihusta86@gmail.com> Signed-off-by: Ivan Valdes <ivan@vald.es>
Member
Author
|
/retest |
ahrtr
approved these changes
May 10, 2024
Member
ahrtr
left a comment
There was a problem hiding this comment.
LGTM
Please also update 3.5 changelog, thx
serathius
approved these changes
May 10, 2024
ivanvc
added a commit
to ivanvc/etcd
that referenced
this pull request
May 10, 2024
Signed-off-by: Ivan Valdes <ivan@vald.es>
ahrtr
added a commit
that referenced
this pull request
May 11, 2024
changelog: add note from #17977 backport
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR backports #17277
Part of #16052.
Please read https://github.com/etcd-io/etcd/blob/main/CONTRIBUTING.md#contribution-flow.