Skip to content

[release-3.5] backport fix watch event loss after compaction#17612

Merged
ahrtr merged 1 commit intoetcd-io:release-3.5from
chaochn47:release-3.5-backport-fix-watch-event-loss-after-compact
Mar 19, 2024
Merged

[release-3.5] backport fix watch event loss after compaction#17612
ahrtr merged 1 commit intoetcd-io:release-3.5from
chaochn47:release-3.5-backport-fix-watch-event-loss-after-compact

Conversation

@chaochn47
Copy link
Copy Markdown
Member

@chaochn47 chaochn47 commented Mar 19, 2024

@chaochn47
[release-3.5] backport fix watch event loss after compaction
46d2caa 
Signed-off-by: Chao Chen <chaochn@amazon.com>
@chaochn47 chaochn47 mentioned this pull request Mar 19, 2024
Merged
@jmhbnz jmhbnz mentioned this pull request Mar 19, 2024
Closed
2 tasks
@ahrtr
Copy link
Copy Markdown
Member

ahrtr commented Mar 19, 2024

Thanks for the PR.

I do not see the integration test case, did you intentionally not backporting the integration test?

@chaochn47
Copy link
Copy Markdown
Member Author

chaochn47 commented Mar 19, 2024

I do not see the integration test case, did you intentionally not backporting the integration test?

@ahrtr

Yeah, go failpoint in the mainline integration test is not supported in release-3.5.

I can create one similar e2e test just like TestLeaseRevoke_IgnoreOldLeader though.

@ahrtr
Copy link
Copy Markdown
Member

ahrtr commented Mar 19, 2024

Thanks for the clarification. I am OK to leave it as it's for now.

ahrtr
ahrtr approved these changes Mar 19, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@ahrtr ahrtr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Thanks

cc @fuweid @jmhbnz @serathius

@ahrtr ahrtr merged commit 2ee038d into etcd-io:release-3.5 Mar 19, 2024
@ahrtr
Copy link
Copy Markdown
Member

ahrtr commented Mar 19, 2024

Please also update the changelog for 3.4 and 3.5, thx

@chaochn47 chaochn47 deleted the release-3.5-backport-fix-watch-event-loss-after-compact branch March 19, 2024 21:49
@chaochn47
Copy link
Copy Markdown
Member Author

chaochn47 commented Mar 20, 2024

Thanks @ahrtr for releasing v3.4.31!

Is there a ETA for releasing [v3.5.13] including the bug fix so we can count on? @serathius

@jmhbnz jmhbnz mentioned this pull request Mar 21, 2024
Closed
3 tasks
@jmhbnz
Copy link
Copy Markdown
Member

jmhbnz commented Mar 21, 2024

Is there a ETA for releasing [v3.5.13] including the bug fix so we can count on? @serathius

Created planning issue #17633 to start the process.

@liangyuanpeng liangyuanpeng mentioned this pull request Mar 22, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@serathius serathius serathius approved these changes

@ahrtr ahrtr ahrtr approved these changes

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@chaochn47 @ahrtr @jmhbnz @serathius