[3.5] Backport disable following redirects when checking peer urls#17024
Merged
serathius merged 1 commit intoetcd-io:release-3.5from Nov 28, 2023
jmhbnz:backport-ssrf-fix
Merged
[3.5] Backport disable following redirects when checking peer urls#17024serathius merged 1 commit intoetcd-io:release-3.5from jmhbnz:backport-ssrf-fix
serathius merged 1 commit intoetcd-io:release-3.5from
jmhbnz:backport-ssrf-fix
Conversation
It's possible that etcd server may run into SSRF situation when adding a new member. If users provide a malicious peer URL, the existing etcd members may be redirected to other unexpected internal URL when getting the new member's version. Signed-off-by: James Blair <mail@jamesblair.net>
serathius
approved these changes
Nov 27, 2023
Contributor
|
@serathius and @jmhbnz Can this merged? With this, we will be ready to move ahead with the release of 3.5.11 |
Member
|
Let me merge it. Issue was proposed by Benjamin with intention of being backported. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It's possible that etcd server may run into SSRF situation when adding a new member. If users provide a malicious peer URL, the existing etcd members may be redirected to other unexpected internal URL when getting the new member's version.
Backports: