fix: false positives for static expressions in detect-non-literal-fs-filename, detect-child-process, detect-non-literal-regexp, and detect-non-literal-require#109
Conversation
1479889 to
6dfa9c4
Compare
Contributor
|
#108 has been merged. |
…filename, detect-child-process, detect-non-literal-regexp, and detect-non-literal-require
Member
Author
|
I have rebased this PR! |
|
@ota-meshi am I missing something, or should this PR in reality have fixed something like: const scriptDirectory = import.meta.dirname;
const outputDirectoryPath = path.resolve(scriptDirectory, 'output');
await fs.mkdir(outputDirectoryPath, { recursive: true }); |
Member
Author
|
|
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR improves 4 rules and changes them to track the expression used and not report when it is a static value.
They will no longer be reported after the change in this PR.
close #65
close #49
related to #22