feat: make TextSourceCodeBase a generic type#182
Merged
nzakas merged 3 commits intoeslint:mainfrom Apr 28, 2025
Merged
Conversation
fasttime
reviewed
Apr 27, 2025
fasttime
approved these changes
Apr 28, 2025
Member
fasttime
left a comment
There was a problem hiding this comment.
LGTM, thanks! Leaving open for a second review.
Closed
This was referenced Apr 30, 2025
snitin315
pushed a commit
that referenced
this pull request
Mar 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prerequisites checklist
What is the purpose of this pull request?
Hello,
This PR addresses issue eslint/markdown#341.
What changes did you make? (Give an overview)
I exported
SourceCodeBaseTypeOptionsfrom@eslint/coreand used it.I also added tests to validate the changes.
Let me know if there's anything else I should do!
Related Issues
fixes eslint/markdown#341
Is there anything you'd like reviewers to focus on?