Skip to content

chore: add lint:unused script to run Knip#206

Merged
nzakas merged 6 commits intomainfrom
chore/configure-knip
Mar 9, 2026
Merged

chore: add lint:unused script to run Knip#206
nzakas merged 6 commits intomainfrom
chore/configure-knip

Conversation

@Pixel998
Copy link
Copy Markdown
Contributor

Prerequisites checklist

What is the purpose of this pull request?

Adds Knip to check for unused exports, unused dependencies, and missing dependencies

What changes did you make? (Give an overview)

  • Added knip.json config and a root lint:unused script.
  • Added a "Lint Files, Dependencies, & Exports" step to our CI.

Related Issues

eslint/js#695

Is there anything you'd like reviewers to focus on?

@Pixel998 Pixel998 requested a review from a team as a code owner January 30, 2026 00:16
@eslintbot eslintbot added this to Triage Jan 30, 2026
@github-project-automation github-project-automation Bot moved this to Needs Triage in Triage Jan 30, 2026
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Feb 9, 2026

Hi everyone, it looks like we lost track of this pull request. Please review and see what the next steps are. This pull request will auto-close in 7 days without an update.

@github-actions github-actions Bot added the Stale label Feb 9, 2026
@DMartens DMartens moved this from Needs Triage to Implementing in Triage Feb 11, 2026
@DMartens
Copy link
Copy Markdown

Changes LGTM besides my notes from the other two PRs which also affect this PR.

@github-actions github-actions Bot removed the Stale label Feb 11, 2026
DMartens
DMartens previously approved these changes Feb 20, 2026
Copy link
Copy Markdown

@DMartens DMartens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes LGTM, thanks (left open as a review from the TSC was requested).

@DMartens DMartens moved this from Implementing to Second Review Needed in Triage Feb 20, 2026
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Mar 2, 2026

Hi everyone, it looks like we lost track of this pull request. Please review and see what the next steps are. This pull request will auto-close in 7 days without an update.

@github-actions github-actions Bot added the Stale label Mar 2, 2026
@fasttime
Copy link
Copy Markdown
Member

fasttime commented Mar 4, 2026

There's a merge conflict now.

@fasttime fasttime added accepted and removed Stale labels Mar 4, 2026
Copy link
Copy Markdown
Member

@nzakas nzakas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@nzakas nzakas merged commit b0b62d8 into main Mar 9, 2026
33 checks passed
@nzakas nzakas deleted the chore/configure-knip branch March 9, 2026 20:48
@github-project-automation github-project-automation Bot moved this from Second Review Needed to Complete in Triage Mar 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: Complete

Development

Successfully merging this pull request may close these issues.

5 participants