feat: Add and use SourceCode#getLoc/getRange#18703
Merged
mdjermanovic merged 5 commits intomainfrom Jul 24, 2024
Merged
Conversation
✅ Deploy Preview for docs-eslint canceled.
|
Member
mdjermanovic
left a comment
There was a problem hiding this comment.
Few more places that should also be updated, I believe, because they're using .loc or .range of nodes:
eslint/lib/linter/report-translator.js
Line 100 in 53b1ff0
eslint/lib/linter/rule-fixer.js
Line 49 in 53b1ff0
eslint/lib/linter/rule-fixer.js
Line 72 in 53b1ff0
eslint/lib/linter/rule-fixer.js
Line 95 in 53b1ff0
eslint/lib/linter/rule-fixer.js
Line 120 in 53b1ff0
Member
Author
|
Thanks! |
This was referenced Aug 18, 2024
This was referenced Aug 18, 2024
This was referenced Aug 19, 2024
This was referenced Sep 23, 2024
This was referenced Sep 29, 2024
This was referenced Oct 26, 2024
This was referenced Oct 29, 2024
This was referenced Oct 30, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prerequisites checklist
What is the purpose of this pull request? (put an "X" next to an item)
[ ] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofix to a rule
[ ] Add a CLI option
[x] Add something to the core
[ ] Other, please explain:
What changes did you make? (Give an overview)
SourceCode#getRange()andSourceCode.getLoc()Linter,applyDisableDirectives()to use the new methods instead of pulling from the node/tokenRefs #18695
Depends on eslint/rewrite#89
Is there anything you'd like reviewers to focus on?