docs: Add system theme option#18617
Conversation
✅ Deploy Preview for docs-eslint ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Can you once check the layout in tablet mode? |
JoshuaKGoldberg
left a comment
There was a problem hiding this comment.
I started reviewing functionally, but then discovered what looks like a user-facing bug. I'll hold off on reviewing more functional stuff in case that bug's fixing necessitates some refactors. Thanks for getting started on this! 🌞
|
Hi everyone, it looks like we lost track of this pull request. Please review and see what the next steps are. This pull request will auto-close in 7 days without an update. |
|
I am working on this PR. |
|
Hi everyone, it looks like we lost track of this pull request. Please review and see what the next steps are. This pull request will auto-close in 7 days without an update. |
|
Ah, I missed that it's waiting on my review - reviewing now. |
JoshuaKGoldberg
left a comment
There was a problem hiding this comment.
💯 this looks great!
Prerequisites checklist
What is the purpose of this pull request? (put an "X" next to an item)
[ ] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofix to a rule
[ ] Add a CLI option
[ ] Add something to the core
[x] Other, please explain:
Added a system theme option and set it as the default selection.
What changes did you make? (Give an overview)
Added a system theme option and set it as the default selection.
Fixes: #18190
Is there anything you'd like reviewers to focus on?
Ensure the changes work across all screen sizes, including tablets and mobile devices.