chore: make internal-rules not being a package#18601
Merged
Conversation
✅ Deploy Preview for docs-eslint canceled.
|
nzakas
reviewed
Jun 18, 2024
| "eslint-plugin-eslint-plugin": "^6.0.0", | ||
| "eslint-plugin-internal-rules": "file:tools/internal-rules", | ||
| "eslint-release": "^3.2.2", | ||
| "eslint-rule-composer": "^0.3.0", |
Member
Author
There was a problem hiding this comment.
Yes, it's used by the internal multiline-comment-style rule:
It was a dependency in the removed package.json so we now need to add it as a dev dependency in the root package.json.
This was referenced Jul 19, 2024
This was referenced Jul 25, 2024
This was referenced Jul 28, 2024
This was referenced Aug 19, 2024
This was referenced Sep 3, 2024
This was referenced Sep 14, 2024
This was referenced Sep 23, 2024
This was referenced Sep 29, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prerequisites checklist
What is the purpose of this pull request? (put an "X" next to an item)
[ ] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofix to a rule
[ ] Add a CLI option
[ ] Add something to the core
[x] Other, please explain:
Now that we're no longer using
.eslintrc.js,tools/internal-rulesdoesn't need to be a package since we can load local plugins directly in the config file. This is also an example of how to easily use internal rules in the new config system.What changes did you make? (Give an overview)
Removed
tools/internal-rules/package.jsonand updated the usage accordingly.Is there anything you'd like reviewers to focus on?