Skip to content

feat: add ecmaVersion: 2025, parsing duplicate named capturing groups#18596

Merged
mdjermanovic merged 1 commit intomainfrom
es2025
Jun 18, 2024
Merged

feat: add ecmaVersion: 2025, parsing duplicate named capturing groups#18596
mdjermanovic merged 1 commit intomainfrom
es2025

Conversation

@mdjermanovic
Copy link
Copy Markdown
Member

@mdjermanovic mdjermanovic commented Jun 17, 2024

Prerequisites checklist

What is the purpose of this pull request? (put an "X" next to an item)

[ ] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofix to a rule
[ ] Add a CLI option
[x] Add something to the core
[ ] Other, please explain:

Adds ecmaVersion: 2025 and enables parsing regexp duplicate named capturing groups with the default parser.

Refs #18330.

What changes did you make? (Give an overview)

Updated espree dependency and updated latest ecmaVersion to 2025.

Is there anything you'd like reviewers to focus on?

@mdjermanovic mdjermanovic requested a review from a team as a code owner June 17, 2024 15:07
@eslint-github-bot eslint-github-bot Bot added the feature This change adds a new feature to ESLint label Jun 17, 2024
@netlify
Copy link
Copy Markdown

netlify Bot commented Jun 17, 2024

Deploy Preview for docs-eslint ready!

Name Link
🔨 Latest commit 061a528
🔍 Latest deploy log https://app.netlify.com/sites/docs-eslint/deploys/66705120fcac01000839b5f5
😎 Deploy Preview https://deploy-preview-18596--docs-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@mdjermanovic mdjermanovic added core Relates to ESLint's core APIs and features accepted There is consensus among the team that this change meets the criteria for inclusion labels Jun 17, 2024
Copy link
Copy Markdown
Member

@nzakas nzakas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Just leaving open to give others a chance to review.

@mdjermanovic mdjermanovic merged commit 8824aa1 into main Jun 18, 2024
@mdjermanovic mdjermanovic deleted the es2025 branch June 18, 2024 15:18
@eslint-github-bot eslint-github-bot Bot locked and limited conversation to collaborators Dec 16, 2024
@eslint-github-bot eslint-github-bot Bot added the archived due to age This issue has been archived; please open a new issue for any further discussion label Dec 16, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

accepted There is consensus among the team that this change meets the criteria for inclusion archived due to age This issue has been archived; please open a new issue for any further discussion core Relates to ESLint's core APIs and features feature This change adds a new feature to ESLint

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

2 participants