feat(desktop): use a fresh signing key; add genkey/verify#2467
Merged
Conversation
The v1 minisign private key wasn't recoverable (no local backup, and a GitHub secret can't be read back), so the desktop updater uses a brand-new minisign key pair rather than reusing v1's. v2 is an independent update line, so a fresh key is cleaner regardless. - internal/update: embed the new public key (ID AF12CA46F4A9EBB0). - cmd/sign: add `genkey <dir>` (generate a key pair) and `verify <file>` (check a .minisig against the embedded key — a sign/verify self-test). - README: update the verification public key. The private key and password live only in ~/.reasonix-keys locally; set them as the MINISIGN_PRIVATE_KEY / MINISIGN_PASSWORD secrets before the first release.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The v1 minisign private key wasn't recoverable (no local backup, and a GitHub secret can't be read back), so the desktop updater uses a fresh minisign key pair instead of reusing v1's — v2 is an independent update line anyway.
internal/update: embed the new public key (IDAF12CA46F4A9EBB0).cmd/sign:genkey <dir>generates a pair;verify <file>checks a.minisigagainst the embedded key (a sign/verify self-test).Verified locally:
go test ./...green; signed an artifact with the new private key andverifyconfirmed it against the embedded public key.Before the first
desktop-v*release, setMINISIGN_PRIVATE_KEY/MINISIGN_PASSWORDsecrets (the key generated into ~/.reasonix-keys).