fix(tui): add shift+enter to InsertNewline key binding, with test#2425
Merged
Conversation
732a8e6 to
4f781c3
Compare
Shift+Enter now inserts a newline alongside Alt+Enter and Ctrl+J. Terminals that don't distinguish Shift+Enter from Enter (macOS Terminal.app, VS Code) are unchanged — use Alt+Enter or Ctrl+J there.
The original test built its own textarea + binding and asserted shift+enter was present — tautological (it checked the keys it had just set). Now it constructs the real chatTUI via newChatTUI and asserts on m.input's actual binding, so it catches a regression that drops shift+enter from the constructor.
4f781c3 to
cf99303
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
`InsertNewline` binding now includes `shift+enter` (was only `alt+enter` and `ctrl+j`).
Why
Shift+Enter for newline is standard TUI behaviour. The existing comment already expresses the intent (Enter=submit, modifier+Enter=newline), but Shift+Enter was simply missed from the key list.
Test
`TestInsertNewlineKeyBinding` verifies `shift+enter` appears in the binding's keys.
Note
Only works when the terminal actually distinguishes Shift+Enter from Enter (Kitty, WezTerm, iTerm2 with config). Terminals that don't (macOS Terminal.app, VS Code) are unchanged — use Alt+Enter or Ctrl+J instead.