Enhancement: Resolve values for keys referring to ::class pseudo constants from the original name instead of the fully-qualified class name#265
Merged
localheinz merged 1 commit intomainfrom Dec 21, 2025
Conversation
b90f9ea to
9ba7718
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #265 +/- ##
============================================
+ Coverage 59.86% 61.14% +1.27%
- Complexity 34 36 +2
============================================
Files 4 4
Lines 152 157 +5
============================================
+ Hits 91 96 +5
Misses 61 61 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
9ba7718 to
54d5d81
Compare
localheinz
commented
Dec 21, 2025
Comment on lines
135
to
+136
| Bicycle::class => 'bicycle', | ||
| Namespaced\Apple::class => 'apple', |
Member
Author
There was a problem hiding this comment.
This sorting order feels more natural.
7332879 to
719a7bf
Compare
…tants from the original name instead of the fully-qualified class name
719a7bf to
4599c2f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request
::classpseudo constants from the original name instead of the fully-qualified class name