Skip to content

Enhancement: Implement NoNamedArgumentRule#916

Merged
localheinz merged 1 commit intomainfrom
feature/no-named-argument
May 31, 2025
Merged

Enhancement: Implement NoNamedArgumentRule#916
localheinz merged 1 commit intomainfrom
feature/no-named-argument

Conversation

@localheinz
Copy link
Member

@localheinz localheinz commented Feb 18, 2025 •
edited
Loading

This pull request

  • implements a NoNamedArgumentRule, which reports an error when an anonymous function, a function, or a method is invoked using a named argument

@localheinz localheinz self-assigned this Feb 18, 2025
@codecov
Copy link

codecov bot commented Feb 18, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 96.15385% with 4 lines in your changes missing coverage. Please review.

Project coverage is 98.43%. Comparing base (a5c42ad) to head (d6ea21e).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
src/CallLikes/NoNamedArgumentRule.php 98.00% 2 Missing ⚠️
src/ErrorIdentifier.php 50.00% 2 Missing ⚠️
Additional details and impacted files 
@@             Coverage Diff              @@
##               main     #916      +/-   ##
============================================
- Coverage     98.71%   98.43%   -0.28%     
- Complexity      226      240      +14     
============================================
  Files            30       31       +1     
  Lines           857      961     +104     
============================================
+ Hits            846      946     +100     
- Misses           11       15       +4

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@localheinz localheinz force-pushed the feature/no-named-argument branch 6 times, most recently from 663f926 to 4fe1667 Compare May 31, 2025 17:45
@localheinz localheinz marked this pull request as ready for review May 31, 2025 17:46
@localheinz localheinz requested a review from ergebnis-bot as a code owner May 31, 2025 17:46
@localheinz localheinz force-pushed the feature/no-named-argument branch 2 times, most recently from 3b5c0fa to 9b50e64 Compare May 31, 2025 20:26
@localheinz localheinz force-pushed the feature/no-named-argument branch from 9b50e64 to d6ea21e Compare May 31, 2025 20:31
@localheinz localheinz merged commit ca3a066 into main May 31, 2025
23 of 25 checks passed
@localheinz localheinz deleted the feature/no-named-argument branch May 31, 2025 20:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ergebnis-bot ergebnis-bot Awaiting requested review from ergebnis-bot ergebnis-bot is a code owner

Assignees

@localheinz localheinz

Labels

enhancement

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@localheinz @ergebnis-bot