Skip to content

Fix: Adjust CallLikes\NoNamedArgumentRule to handle calls on callables assigned to properties#950

Merged
localheinz merged 2 commits intomainfrom
fix/property-fetch
Jun 6, 2025
Merged

Fix: Adjust CallLikes\NoNamedArgumentRule to handle calls on callables assigned to properties#950
localheinz merged 2 commits intomainfrom
fix/property-fetch

Conversation

@localheinz
Copy link
Member

@localheinz localheinz commented Jun 6, 2025

This pull request

  • adds a test case for invoking invokable assigned to instance property with named arguments
  • adjusts CallLikes\NoNamedArgumentRule to handle calls on callables assigned to properties

Fixes #946.

@localheinz localheinz self-assigned this Jun 6, 2025
@localheinz localheinz requested a review from ergebnis-bot as a code owner June 6, 2025 16:28
@localheinz localheinz changed the title Fix: Add test case for invoking invokable assigned to instance property with named arguments Fix: Adjust CallLikes\NoNamedArgumentRule to handle calls on callables assigned to properties Jun 6, 2025
@codecov
Copy link

codecov bot commented Jun 6, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.34%. Comparing base (c688608) to head (0da8520).
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##               main     #950   +/-   ##
=========================================
  Coverage     98.33%   98.34%           
- Complexity      307      308    +1     
=========================================
  Files            37       37           
  Lines          1262     1267    +5     
=========================================
+ Hits           1241     1246    +5     
  Misses           21       21           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@localheinz localheinz force-pushed the fix/property-fetch branch 2 times, most recently from c371667 to 13f9553 Compare June 6, 2025 16:36
@localheinz localheinz force-pushed the fix/property-fetch branch from 13f9553 to a82f643 Compare June 6, 2025 16:39
@localheinz localheinz merged commit fe2cc21 into main Jun 6, 2025
25 checks passed
@localheinz localheinz deleted the fix/property-fetch branch June 6, 2025 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Error with named arguments in 2.10.3

2 participants