Skip to content

Fix: Adjust CallLikes\NoNamedArgumentRule to handle calls on invokables#948

Merged
localheinz merged 2 commits intomainfrom
fix/property-fetch
Jun 6, 2025
Merged

Fix: Adjust CallLikes\NoNamedArgumentRule to handle calls on invokables#948
localheinz merged 2 commits intomainfrom
fix/property-fetch

Conversation

@localheinz
Copy link
Member

@localheinz localheinz commented Jun 6, 2025 •
edited
Loading

This pull request

  • adds a test case for invoking an invokable with named arguments
  • adjusts CallLikes\NoNamedArgumentRule to handle calls on invokables

Related to #946.

@localheinz localheinz self-assigned this Jun 6, 2025
@localheinz localheinz requested a review from ergebnis-bot as a code owner June 6, 2025 14:51
@localheinz localheinz force-pushed the fix/property-fetch branch 2 times, most recently from 4026c4c to 2c9a2c0 Compare June 6, 2025 15:39
@localheinz localheinz changed the title Fix: Add test case for invoking an invokable assigned to a property with named arguments Fix: Add test case for invoking an invokable with named arguments Jun 6, 2025
@localheinz localheinz force-pushed the fix/property-fetch branch from 2c9a2c0 to 209e4ff Compare June 6, 2025 16:10
@localheinz localheinz force-pushed the fix/property-fetch branch from 209e4ff to 737545b Compare June 6, 2025 16:10
@localheinz localheinz changed the title Fix: Add test case for invoking an invokable with named arguments Fix: Adjust CallLikes\NoNamedArgumentRule to handle calls on invokables Jun 6, 2025
@codecov
Copy link

codecov bot commented Jun 6, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.33%. Comparing base (a5c34af) to head (705834c).
Report is 3 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff            @@
##               main     #948   +/-   ##
=========================================
  Coverage     98.33%   98.33%           
  Complexity      307      307           
=========================================
  Files            37       37           
  Lines          1262     1262           
=========================================
  Hits           1241     1241           
  Misses           21       21

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@localheinz localheinz merged commit 8c84b79 into main Jun 6, 2025
25 checks passed
@localheinz localheinz deleted the fix/property-fetch branch June 6, 2025 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ergebnis-bot ergebnis-bot Awaiting requested review from ergebnis-bot ergebnis-bot is a code owner

Assignees

@localheinz localheinz

Labels

bug

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@localheinz @ergebnis-bot