Fix Cache Key Calculation in Phive Install GitHub Action#197
Merged
localheinz merged 1 commit intoergebnis:mainfrom Jun 7, 2024
lotyp:fix/phive-install
Merged
Fix Cache Key Calculation in Phive Install GitHub Action#197localheinz merged 1 commit intoergebnis:mainfrom lotyp:fix/phive-install
localheinz merged 1 commit intoergebnis:mainfrom
lotyp:fix/phive-install
Conversation
localheinz
approved these changes
Jun 7, 2024
Member
|
Thank you, @lotyp! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
I've noticed a bug in the Phive install action where the cache key is incorrectly calculated. Instead of generating a hash from
phars.xml, the function name is printed as a string, leading to cache failures whenphars.xmlis updated in a single pull request.Current Output:
Fix:
I updated the cache key calculation from:
to:
After fix is applied:
This should ensure the correct hash is generated and the cache is restored properly.
I encountered a similar issue in my wayofdev/gh-actions repository, which also uses Phive install inspired by your repository.
How to check cache keys?:
https://github.com/cli/cli can be used to check all cache keys of repository: