Skip to content

Apply get_client_addr formatting to WebSocket logging#2636

Merged
Kludex merged 1 commit intoKludex:masterfrom
Harry-Lees:update-websocket-logging
May 14, 2025
Merged

Apply get_client_addr formatting to WebSocket logging#2636
Kludex merged 1 commit intoKludex:masterfrom
Harry-Lees:update-websocket-logging

Conversation

@Harry-Lees
Copy link
Contributor

Summary

Update address formatting in websocket logging. Previously, the incoming address for websockets was logged as follows:

INFO:     ('127.0.0.1', 55200) - "WebSocket /test" [accepted]

This PR updates the logging to match other HTTP methods.

INFO:     127.0.0.1:55315 - "WebSocket /test" [accepted]

Checklist

  • I understand that this PR may be closed in case there was no previous discussion. (This doesn't apply to typos!)
  • I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change.
  • I've updated the documentation accordingly.

@Kludex Kludex merged commit fa3d9d2 into Kludex:master May 14, 2025
16 checks passed
@Kludex
Copy link
Owner

Kludex commented May 14, 2025

Thanks :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants