Use same module (httpx|httpx2) for type checking as for runtime#3304
Merged
Conversation
Kludex
approved these changes
May 30, 2026
Owner
|
Yes, this is what I meant. |
Merged
Kludex
added a commit
that referenced
this pull request
May 31, 2026
|
This seems to have lost typing information: the return type of |
|
It seems like I could add the edit Oh, that's only on |
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Using different module when type checking (httpx) compared to runtime (httpx2) will cause type
checkers like pyright to fail. This PR solves this issue mentioned in #3302
Checklist
Use same module (httpx|httpx2) for type checking as for runtime