Merged
Conversation
karpetrosyan
reviewed
Feb 4, 2024
Comment on lines
+75
to
+96
| **Establishing the connection** | ||
|
|
||
| * `"connection.connect_tcp"` | ||
| * `"connection.connect_unix_socket"` | ||
| * `"connection.start_tls"` | ||
|
|
||
| **HTTP/1.1 events** | ||
|
|
||
| * `"http11.send_request_headers"` | ||
| * `"http11.send_request_body"` | ||
| * `"http11.receive_response"` | ||
| * `"http11.receive_response_body"` | ||
| * `"http11.response_closed"` | ||
|
|
||
| **HTTP/2 events** | ||
|
|
||
| * `"http2.send_connection_init"` | ||
| * `"http2.send_request_headers"` | ||
| * `"http2.send_request_body"` | ||
| * `"http2.receive_response_headers"` | ||
| * `"http2.receive_response_body"` | ||
| * `"http2.response_closed"` |
Contributor
There was a problem hiding this comment.
Maybe we shouldn't list all of the supported events here. We should remember to update this list every time we introduce a new event to httpcore. We could simply mention them in httpcore and provide a link here.
Contributor
There was a problem hiding this comment.
(an automatic workflow here would also help - mkdocs plugins are easy to implement)
karpetrosyan
reviewed
Feb 4, 2024
Co-authored-by: Kar Petrosyan <92274156+karpetrosyan@users.noreply.github.com>
karpetrosyan
approved these changes
Feb 6, 2024
shepilov-vladislav
pushed a commit
to shepilov-vladislav/httpx
that referenced
this pull request
Mar 28, 2024
* Deprecate app=... in favour of explicit WSGITransport/ASGITransport * Linting * Linting * Update WSGITransport and ASGITransport docs * Deprecate app * Drop deprecation tests * Add CHANGELOG * Deprecate 'app=...' shortcut, rather than removing it. * Update CHANGELOG * Fix test_asgi.test_deprecated_shortcut * Extensions docs * Include 'extensions' in docs index * Update docs/advanced/extensions.md Co-authored-by: Kar Petrosyan <92274156+karpetrosyan@users.noreply.github.com> --------- Co-authored-by: Kar Petrosyan <92274156+karpetrosyan@users.noreply.github.com>
samclearman
pushed a commit
to titanmsp/httpx
that referenced
this pull request
Apr 26, 2025
* Deprecate app=... in favour of explicit WSGITransport/ASGITransport * Linting * Linting * Update WSGITransport and ASGITransport docs * Deprecate app * Drop deprecation tests * Add CHANGELOG * Deprecate 'app=...' shortcut, rather than removing it. * Update CHANGELOG * Fix test_asgi.test_deprecated_shortcut * Extensions docs * Include 'extensions' in docs index * Update docs/advanced/extensions.md Co-authored-by: Kar Petrosyan <92274156+karpetrosyan@users.noreply.github.com> --------- Co-authored-by: Kar Petrosyan <92274156+karpetrosyan@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #2599.
Mostly cribbed from the
httpcoredocumentation.timeoutto reflect it as a lower priority in this case. Users should be using thetimeout=...API withhttpx.network_streamdocs don't currently include aCONNECTexample. In order to support this we'd need to be able to specify the request target explicitly, since we currently only support requests that use the standard HTTP/1.1 abs-path. Supporting atargetrequest extension would allow us to supportOPTIONS *requests, proxy absolute-url requests, non-standard path quoting andCONNECTrequests.network_streamdocs don't currently include anUpgradeexample. This discussion correctly identifies that we need to handle theh11tailing_data in order to properly support that. See Support connectionUpgradeandCONNECT. httpcore#872