Add section about avoiding N+1 queries in generic views#9801
Merged
auvipy merged 1 commit intoencode:mainfrom Oct 20, 2025
Merged
Add section about avoiding N+1 queries in generic views#9801auvipy merged 1 commit intoencode:mainfrom
auvipy merged 1 commit intoencode:mainfrom
Conversation
Member
browniebroke
left a comment
There was a problem hiding this comment.
Looks good, I left a few minor suggestions
27fa551 to
515c434
Compare
Contributor
Author
@browniebroke Thanks ! |
browniebroke
approved these changes
Oct 20, 2025
auvipy
approved these changes
Oct 20, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I noticed that DRF mentions N+1 problems briefly in a note under get_queryset(), but it doesn’t give any proper explanation or examples.
I added a new section about performance and N+1 queries. It explains why the issue happens and how to use
select_relatedandprefetch_relatedinget_queryset()for generic views and viewsets. I also included short examples.The goal is to make it clearer for new people and avoid confusion.