Add missing decorators: @versioning_class(), @content_negotiation_class(), @metadata_class() for function-based views#9719
Merged
browniebroke merged 4 commits intoencode:mainfrom Sep 20, 2025
Conversation
qqii
added a commit
to qqii/adrf
that referenced
this pull request
Jul 7, 2025
qqii
added a commit
to qqii/adrf
that referenced
this pull request
Jul 7, 2025
Member
Yes, I think that if you add one, it makes sense to add all 3 that you found were missing 👍🏻 |
@versioning_class()@versioning_class(), @content_negotiation_class(), @metadata_class()
Contributor
Author
|
Sure @browniebroke, I've amended this PR to add all of them. Do the tests for |
auvipy
requested changes
Aug 10, 2025
Collaborator
auvipy
left a comment
There was a problem hiding this comment.
may be we have to update the relevant docs for these, as well?
0130ddd to
7122568
Compare
browniebroke
approved these changes
Aug 13, 2025
Contributor
Author
|
@auvipy are also happy with this PR? |
auvipy
approved these changes
Aug 21, 2025
Contributor
Author
|
What are my next steps for getting this merged? |
Member
Nothing, really. We're going to include it in 3.17 but there are a few smaller fixes that could go in a 3.16.2 so we'll have to review if we release them under 3.16.x before merging this. |
@versioning_class(), @content_negotiation_class(), @metadata_class()@versioning_class(), @content_negotiation_class(), @metadata_class() for function-based views
@versioning_class(), @content_negotiation_class(), @metadata_class() for function-based views @versioning_class(), @content_negotiation_class(), @metadata_class() for function-based views
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds the three missing decorators, fixing #9716.
@content_negotiation_class()@metadata_class()@versioning_class()