stm32/sai: make NODIV independent of MCKDIV#4589
Merged
lulf merged 3 commits intoembassy-rs:mainfrom Aug 26, 2025
Merged
Conversation
auto-merge was automatically disabled
August 26, 2025 09:21
Head branch was pushed to by a user without write access
auto-merge was automatically disabled
August 26, 2025 09:43
Head branch was pushed to by a user without write access
Contributor
Author
|
@lulf I had to merge the changelog and the auto-merge got disabled again |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These values should clearly be made independent, at least in the WB55 microcontroller (and so I suspect in all the others) since NODIV implies no divider between the master clock and the bit clock, but it does NOT imply no divider between the SAI clock and the master clock. Quoting from the WB55 reference manual (RM0434 Rev 14, p. 1219):
Tests I have performed with the WB55 show you can use
NODIV = 1withMCKDIV != disabledand still get valid configurations and correct clock frequencies.I'm not entirely sure about integrating this change though since CubeMX follows the same behaviour as Embassy currently (i.e. NODIV == MCKDIV disabled).