Skip to content

fix(components): [cascader] failed to retrieve value when value is 0#17651

Merged
tolking merged 2 commits intoelement-plus:devfrom
tuskermanshu:#17272
Jul 25, 2024
Merged

fix(components): [cascader] failed to retrieve value when value is 0#17651
tolking merged 2 commits intoelement-plus:devfrom
tuskermanshu:#17272

Conversation

@tuskermanshu
Copy link
Copy Markdown
Contributor

Resolved an issue where certain falsy values, such as 0, were incorrectly treated as undefined in data processing and validation logic, ensuring accurate handling and display across all components.

closed #17647

Please make sure these boxes are checked before submitting your PR, thank you!

  • [√ ] Make sure you follow contributing guide English | (中文 | Español | Français).
  • [√ ] Make sure you are merging your commits to dev branch.
  • [ √] Add some descriptions and refer to relative issues for your PR.

Resolved an issue where certain falsy values, such as 0, were incorrectly treated as undefined in
data processing and validation logic, ensuring accurate handling and display across all components.

closed element-plus#17647
do not submit pnpm-lock.yaml.
@pull-request-triage
Copy link
Copy Markdown

👋 @dadaguai-git, seems like this is your first time contribution to element-plus.

  • Please make sure that you have read our guidelines and code of conduct before making a contribution.
  • You can comment with /label Components:[component_name] to add a label for which component you are working on.
  • You may join our Discord for staying tuned.

@pull-request-triage pull-request-triage Bot added 1st contribution Their very first contribution Needs Review labels Jul 24, 2024
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Jul 24, 2024

@github-actions
Copy link
Copy Markdown

Hello @dadaguai-git, thank you for contributing to element-plus, please see our guideline to see how to make contribution

@github-actions
Copy link
Copy Markdown

🧪 Playground Preview: https://element-plus.run/?pr=17651
Please comment the example via this playground if needed.

@btea btea changed the title fix(components): correct data display in Cascader fix(components): [cascader] failed to retrieve value when value is 0 Jul 24, 2024
@tuskermanshu
Copy link
Copy Markdown
Contributor Author

Element Plus Playground

@tolking
Copy link
Copy Markdown
Member

tolking commented Jul 25, 2024

Thank for your contribution

@tolking tolking merged commit f974ea5 into element-plus:dev Jul 25, 2024
@element-bot element-bot mentioned this pull request Jul 26, 2024
3 tasks
@tuskermanshu tuskermanshu deleted the #17272 branch July 30, 2024 01:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Component] [cascader] el-cascader emitPath设为false 时 value 为数字0的option @change 会返回undefined

3 participants