Skip to content

flx(component): buttonColor is calculated in the 'var' case#17319

Merged
btea merged 6 commits intoelement-plus:devfrom
webvs2:dev-button
Jun 28, 2024
Merged

flx(component): buttonColor is calculated in the 'var' case#17319
btea merged 6 commits intoelement-plus:devfrom
webvs2:dev-button

Conversation

@webvs2
Copy link
Copy Markdown
Contributor

@webvs2 webvs2 commented Jun 25, 2024

Please make sure these boxes are checked before submitting your PR, thank you!

@pull-request-triage
Copy link
Copy Markdown

👋 @webvs2, thank you for contributing element-plus.

  • You can comment with /label Components:[component_name] to add a label for which component you are working on.
  • You may join our Discord for staying tuned.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Jun 25, 2024

@github-actions
Copy link
Copy Markdown

Hello @webvs2, thank you for contributing to element-plus, please see our guideline to see how to make contribution

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Jun 25, 2024

🧪 Playground Preview: https://element-plus.run/?pr=17319
Please comment the example via this playground if needed.

@kooriookami
Copy link
Copy Markdown
Member

Please fix the test

@kooriookami kooriookami requested a review from btea June 26, 2024 01:07
@webvs2
Copy link
Copy Markdown
Contributor Author

webvs2 commented Jun 26, 2024

Please fix the test

😉

Comment thread packages/components/button/src/button-custom.ts Outdated
Comment thread packages/components/button/src/button-custom.ts
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Component] [button] Button auto hover and active color not working when color obtained from css variable

3 participants