Skip to content

fix(components): [progress] setting both color and striped is invalid#17235

Merged
btea merged 2 commits intodevfrom
fix/progress-custom-color-striped-invalid
Jun 21, 2024
Merged

fix(components): [progress] setting both color and striped is invalid#17235
btea merged 2 commits intodevfrom
fix/progress-custom-color-striped-invalid

Conversation

@btea
Copy link
Copy Markdown
Member

@btea btea commented Jun 17, 2024

Please make sure these boxes are checked before submitting your PR, thank you!

  • Make sure you follow contributing guide English | (中文 | Español | Français).
  • Make sure you are merging your commits to dev branch.
  • Add some descriptions and refer to relative issues for your PR.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Jun 17, 2024

@github-actions github-actions Bot added the CommitMessage::Qualified Qualified commit message label Jun 17, 2024
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Jun 17, 2024

🧪 Playground Preview: https://element-plus.run/?pr=17235
Please comment the example via this playground if needed.

@wx-11
Copy link
Copy Markdown

wx-11 commented Jun 17, 2024

比较奇怪的是 我看了编辑历史 2.7.1-2.7.2版本之间并没有改动过progress.vue文件 之前也看过 上次修改是去年,那就不知道问题是从何而来的。如果是外部组件或者框架修改 应该把对应框架部分改回2.7.1那样或者相应修复,怎么还是修改到progress.vue文件来了。

我作为一个相关的思考回复放在这里,后面我学明白前端了会来解决这个问题。楼主不用回复我,不想私人问题打扰浪费您的时间。忽略我即可,感谢跟进的修复。

@wx-11
Copy link
Copy Markdown

wx-11 commented Jun 17, 2024

问题找到了 是我没看清楚 看到是同一个作者差不多英文标题 还奇怪pr怎么还没合并就到主分支...原来最新的4.26 就是这个改动导致的 所以改回background-color就可以了。 因为background会覆盖其他背景属性。

我上个月初发现的问题 居然也没发现是4.26那个改动,只看到一个红色的x 还以为是那个还在测试没成功。

image

对比 4.26文件这个pr文件 应该color这里改回去确实可以修复 不是外部框架导致的

疑惑解决了,打扰了评论区 抱歉。

Copy link
Copy Markdown
Member

@FrontEndDog FrontEndDog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CommitMessage::Qualified Qualified commit message

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants