Skip to content

fix(components): [date-picker] support dynamic setting of format#17161

Merged
FrontEndDog merged 4 commits intoelement-plus:devfrom
dddssw:dev
Jun 21, 2024
Merged

fix(components): [date-picker] support dynamic setting of format#17161
FrontEndDog merged 4 commits intoelement-plus:devfrom
dddssw:dev

Conversation

@dddssw
Copy link
Copy Markdown
Contributor

@dddssw dddssw commented Jun 12, 2024 •
edited
Loading

change format will not update component

closed #17149

Please make sure these boxes are checked before submitting your PR, thank you!

  • Make sure you follow contributing guide English | (中文 | Español | Français).
  • Make sure you are merging your commits to dev branch.
  • Add some descriptions and refer to relative issues for your PR.

fix(components): [date-picker]
dd41986 
change format will not update component

closed element-plus#17149
@pull-request-triage
Copy link
Copy Markdown

pull-request-triage Bot commented Jun 12, 2024

👋 @dddssw, seems like this is your first time contribution to element-plus.

  • Please make sure that you have read our guidelines and code of conduct before making a contribution.
  • You can comment with /label Components:[component_name] to add a label for which component you are working on.
  • You may join our Discord for staying tuned.

@pull-request-triage pull-request-triage Bot added 1st contribution Their very first contribution Needs Review labels Jun 12, 2024
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Jun 12, 2024

Hello @dddssw, thank you for contributing to element-plus, please see our guideline to see how to make contribution

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Jun 12, 2024 •
edited
Loading

polikm5
polikm5 reviewed Jun 12, 2024
View reviewed changes
Copy link
Copy Markdown

@polikm5 polikm5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

试了一下 确实是这里的问题

@github-actions github-actions Bot added the CommitMessage::Qualified Qualified commit message label Jun 12, 2024
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Jun 12, 2024 •
edited
Loading

🧪 Playground Preview: https://element-plus.run/?pr=17161
Please comment the example via this playground if needed.

@dddssw
Copy link
Copy Markdown
Contributor Author

dddssw commented Jun 12, 2024

emm,there is a error ?

@warmthsea
Copy link
Copy Markdown
Member

warmthsea commented Jun 12, 2024

emm,there is a error ?

You don't need to deal with it, it's not caused by your code.

@dddssw
Copy link
Copy Markdown
Contributor Author

dddssw commented Jun 12, 2024

all right , thank you @warmthsea

@btea btea changed the title fix(components): [date-picker] fix(components): [date-picker] support dynamic setting of format Jun 13, 2024
btea
btea reviewed Jun 13, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@btea btea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a test case?

@dddssw
Copy link
Copy Markdown
Contributor Author

dddssw commented Jun 13, 2024

Sorry,I don’t know how to add a test case. It would be better if there are articles to guide。 @btea

@btea
Copy link
Copy Markdown
Member

btea commented Jun 14, 2024

You can refer to existing test cases.
https://github.com/element-plus/element-plus/blob/dev/packages/components/date-picker/__tests__/date-picker.test.ts

@dddssw
Copy link
Copy Markdown
Contributor Author

dddssw commented Jun 14, 2024

I wil give a try

dddssw and others added 2 commits June 15, 2024 08:15
@dddssw dddssw requested a review from btea June 15, 2024 00:28
@dddssw
Copy link
Copy Markdown
Contributor Author

dddssw commented Jun 15, 2024

Could you please review the test case I wrote? @btea

btea
btea reviewed Jun 15, 2024
View reviewed changes
Comment thread packages/components/date-picker/__tests__/date-picker.test.ts Outdated
Comment thread packages/components/date-picker/__tests__/date-picker.test.ts Outdated
@dddssw dddssw requested a review from btea June 15, 2024 04:36
@dddssw
Copy link
Copy Markdown
Contributor Author

dddssw commented Jun 15, 2024

Thanks for your review

@btea btea requested a review from ryuhangyeong June 15, 2024 04:39
btea
btea approved these changes Jun 15, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@btea btea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@btea btea requested a review from kooriookami June 21, 2024 03:26
@btea btea requested a review from FrontEndDog June 21, 2024 03:26
FrontEndDog
FrontEndDog approved these changes Jun 21, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@FrontEndDog FrontEndDog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution！

@FrontEndDog FrontEndDog merged commit 6054996 into element-plus:dev Jun 21, 2024
@element-bot element-bot mentioned this pull request Jun 21, 2024
Merged
3 tasks
This was referenced Jul 13, 2024
Merged
Open
@Ramyromel Ramyromel mentioned this pull request Jul 23, 2024
Open
@Samad2011s Samad2011s mentioned this pull request Jul 28, 2024
Open
@Shahzeb892 Shahzeb892 mentioned this pull request Aug 2, 2024
Open
@Bidur2054 Bidur2054 mentioned this pull request Aug 2, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@btea btea btea approved these changes

@FrontEndDog FrontEndDog FrontEndDog approved these changes

@ryuhangyeong ryuhangyeong Awaiting requested review from ryuhangyeong

@kooriookami kooriookami Awaiting requested review from kooriookami

+1 more reviewer

@polikm5 polikm5 polikm5 left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@dddssw dddssw

Labels

1st contribution Their very first contribution CommitMessage::Qualified Qualified commit message Contribution::Community Needs Review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Component] [date-picker] DatePicker format动态修改无效

5 participants

@dddssw @warmthsea @btea @polikm5 @FrontEndDog