style: css uniformly uses px#17101
Merged
btea merged 1 commit intoelement-plus:devfrom Jun 26, 2024
Merged
Conversation
|
👋 @warmthsea, thank you for contributing element-plus.
|
|
|
|
Hello @warmthsea, thank you for contributing to element-plus, please see our guideline to see how to make contribution |
|
🧪 Playground Preview: https://element-plus.run/?pr=17101 |
warmthsea
commented
Jun 6, 2024
Member
Author
warmthsea
left a comment
There was a problem hiding this comment.
Of all the codes, only these two places use rem.
ryuhangyeong
approved these changes
Jun 8, 2024
Member
|
@kooriookami Do you think we need to update this to the issue that records the changes? |
Member
Yes, It would make more sense to use px. |
kooriookami
approved these changes
Jun 25, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixed: #17100