Skip to content

fix(components): date-picker minDate change unexpectedly#16748

Merged
kooriookami merged 1 commit intoelement-plus:devfrom
xiaodong2008:fix/date-time-picker-update-when-input
Jun 18, 2024
Merged

fix(components): date-picker minDate change unexpectedly#16748
kooriookami merged 1 commit intoelement-plus:devfrom
xiaodong2008:fix/date-time-picker-update-when-input

Conversation

@xiaodong2008
Copy link
Copy Markdown
Contributor

Please make sure these boxes are checked before submitting your PR, thank you!

  • Make sure you follow contributing guide English | (中文 | Español | Français).
  • Make sure you are merging your commits to dev branch.
  • Add some descriptions and refer to relative issues for your PR.

What's Changed

Fixed #16667.

This PR moved the checking of maxDate.value.isBefore from input event to change event to prevent minDate change unexpectedly.

@pull-request-triage
Copy link
Copy Markdown

👋 @xiaodong2008, seems like this is your first time contribution to element-plus.

  • Please make sure that you have read our guidelines and code of conduct before making a contribution.
  • You can comment with /label Components:[component_name] to add a label for which component you are working on.
  • You may join our Discord for staying tuned.

@pull-request-triage pull-request-triage Bot added 1st contribution Their very first contribution Needs Review labels May 4, 2024
@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 4, 2024

@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 4, 2024

Hello @xiaodong2008, thank you for contributing to element-plus, please see our guideline to see how to make contribution

@xiaodong2008
Copy link
Copy Markdown
Contributor Author

/label Component::DatePicker

@github-actions github-actions Bot added the CommitMessage::Qualified Qualified commit message label May 6, 2024
@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 6, 2024

🧪 Playground Preview: https://element-plus.run/?pr=16748
Please comment the example via this playground if needed.

Copy link
Copy Markdown
Member

@FrontEndDog FrontEndDog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution!

@FrontEndDog FrontEndDog requested a review from kooriookami May 7, 2024 02:27
@sx529677676
Copy link
Copy Markdown

@kooriookami could you please review this pull request as soon as possible, It is very important to us, thxs!

@kooriookami
Copy link
Copy Markdown
Member

QQ2024618-92450-HD.mp4

Has it really been fixed?

@xiaodong2008
Copy link
Copy Markdown
Contributor Author

It works normally in the playground.

Screen.Recording.2024-06-18.at.11.22.10.mov

@xiaodong2008
Copy link
Copy Markdown
Contributor Author

It works normally in the playground.
Screen.Recording.2024-06-18.at.11.22.10.mov

@xiaodong2008 我看Start Date是空的,另外如果开始日期与结束日期一致的话,修改了后面时间的小时,是否会影响前面的时间呢?可否show一下 image

No, it won't, the date will only be verified and fixed after you blur it.

@sx529677676
Copy link
Copy Markdown

QQ2024618-92450-HD.mp4
Has it really been fixed?

@kooriookami I think what you demonstrated is another bug that is pre-existing,It would be better if it could be solved. But this pull-request has already solved my problem.

@kooriookami kooriookami merged commit ff936c7 into element-plus:dev Jun 18, 2024
@element-bot element-bot mentioned this pull request Jun 21, 2024
3 tasks
@lp4298707
Copy link
Copy Markdown

QQ2024618-92450-HD.mp4
Has it really been fixed?

still not resolve this problem yet

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Component] [All] DateTimePicker 日期时间选择器选择都选择当天日期后输入开始时间再输入结束时间开始时间显示有问题

6 participants