fix: holistic field detection for <text> (sha256 hash) redaction#9834
Merged
Conversation
…lookup and hashing as potentially-sensitive
🦋 Changeset detectedLatest commit: 1bb66ea The changes in this PR will be included in the next version bump. This PR includes changesets to release 12 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overhauls how fields are detected and redacted across HTTP requests, logging, and variable handling. The changes standardize the detection of fields, ensuring consistent hashing in logs and error messages, and make the system extensible for when supporting custom 3rd party Publishers. Several utility functions for redacting field data are now exported and reused throughout the codebase.
normalizeName,isSensitiveFieldName, andhashSensitiveValueutilities to consistently identify and hash sensitive field names and values across the codebase. These now underpin all sensitive data redaction.addSensitiveRedirectHeader,addSensitiveFieldPattern) to allow custom publishers to register additional sensitive headers or field patterns for redaction.