fix: read nodeIntegrationInWorker from per-frame WebPreferences (#50122)#50467
Merged
VerteDinde merged 2 commits into40-x-yfrom Mar 24, 2026
Merged
fix: read nodeIntegrationInWorker from per-frame WebPreferences (#50122)#50467VerteDinde merged 2 commits into40-x-yfrom
VerteDinde merged 2 commits into40-x-yfrom
Conversation
Previously the renderer checked a process-wide command-line switch to decide whether to create a Node.js environment for dedicated workers. When a renderer process hosted multiple WebContents with different nodeIntegrationInWorker values (e.g. via window.open with overridden webPreferences in setWindowOpenHandler), all workers in the process used whichever value the first WebContents set on the command line. Instead, plumb the flag through blink's WorkerSettings at worker creation time, copying it from the initiating frame's WebPreferences. The check on the worker thread then reads the per-worker value. Nested workers inherit the flag from their parent worker via WorkerSettings::Copy. The --node-integration-in-worker command-line switch is removed as it is no longer consumed.
bd93419 to
f2ac5c8
Compare
MarshallOfSound
approved these changes
Mar 24, 2026
…apHandler The backported PR removed this include (matching main where SetUpWebAssemblyTrapHandler was refactored), but on 40-x-y the function still uses base::CommandLine. Co-Authored-By: Claude <svc-devxp-claude@slack-corp.com>
|
Release Notes Persisted
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #50122.
Patch adaptation: updated
dedicated_worker.ccindex hashes for Chromium 144.0.7559.236.Notes: Fixed an issue where
nodeIntegrationInWorkeroverrides insetWindowOpenHandlerwere not honored for child windows sharing a renderer process with their opener.