Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: electron/electron
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v32.1.1
Choose a base ref
...
head repository: electron/electron
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v32.1.2
Choose a head ref
  • 10 commits
  • 35 files changed
  • 8 contributors

Commits on Sep 18, 2024

  1. build: improve logging on http errors during release process (#43762)

    * build: improve logging on http errors during release process (#43756)
    
    Co-authored-by: Samuel Attard <sam@electronjs.org>
    
    * build: improve logging on http errors during release process (again) (#43757)
    
    Co-authored-by: Samuel Attard <sam@electronjs.org>
    
    * build: improve logging on http errors during release process (again, but more) (#43758)
    
    Co-authored-by: Samuel Attard <sam@electronjs.org>
    
    ---------
    
    Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
    Co-authored-by: Samuel Attard <sam@electronjs.org>
    trop[bot] and MarshallOfSound authored Sep 18, 2024
    Configuration menu
    Copy the full SHA
    ca32340 View commit details
    Browse the repository at this point in the history
  2. build: split darwin/mas macOS publish jobs (#43766)

    Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
    Co-authored-by: Samuel Attard <samuel.r.attard@gmail.com>
    trop[bot] and MarshallOfSound authored Sep 18, 2024
    Configuration menu
    Copy the full SHA
    95ae0aa View commit details
    Browse the repository at this point in the history
  3. chore: bump chromium to 128.0.6613.162 (32-x-y) (#43768)

    chore: bump chromium in DEPS to 128.0.6613.162
    
    Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
    electron-roller[bot] authored Sep 18, 2024
    Configuration menu
    Copy the full SHA
    8ab4d24 View commit details
    Browse the repository at this point in the history

Commits on Sep 19, 2024

  1. build: let darwin/mas run concurrently (#43791)

    Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
    Co-authored-by: Samuel Attard <samuel.r.attard@gmail.com>
    trop[bot] and MarshallOfSound authored Sep 19, 2024
    Configuration menu
    Copy the full SHA
    9c88da3 View commit details
    Browse the repository at this point in the history
  2. fix: EyeDropper working in devtools (32-x-y) (#43786)

    fix: EyeDropper working in devtools (#43685)
    
    Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
    ckerr and codebytere authored Sep 19, 2024
    Configuration menu
    Copy the full SHA
    8b49ba1 View commit details
    Browse the repository at this point in the history
  3. build: compile Node.js with C++20 support (32-x-y) (#43785)

    build: compile Node.js with C++20 support (#43555)
    
    * build: compile with C++20 support
    
    * build: update build-image-sha for gcc 10
    
    Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
    ckerr and codebytere authored Sep 19, 2024
    Configuration menu
    Copy the full SHA
    0f11dd9 View commit details
    Browse the repository at this point in the history
  4. refactor: remove use of deprecated API BuildServiceInstanceFor() (3…

    …2-x-y) (#43780)
    
    * refactor: remove use of deprecated API BuildServiceInstanceFor() (#43690)
    
    * refactor: update BadgeManagerFactory
    
    * refactor: update NetworkContextServiceFactory
    
    * refactor: update ElectronExtensionSystemFactory
    
    * refactor: update UsbChooserContextFactory
    
    * refactor: update UsbHidChooserContextFactory
    
    * refactor: update SerialChooserContextFactory
    
    * refactor: update FileSystemAccessPermissionContextFactory
    
    * empty commit
    ckerr authored Sep 19, 2024
    Configuration menu
    Copy the full SHA
    bd9e009 View commit details
    Browse the repository at this point in the history
  5. chore: fix compile issue about ambiguous error of multiple methods na…

    …med 'highlight'. (#43801)
    
    chore: fix ambiguous error of multiple methods named 'highlight'
    
    Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
    Co-authored-by: bill.shen <shenyb32768@gmail.com>
    trop[bot] and cucbin authored Sep 19, 2024
    Configuration menu
    Copy the full SHA
    08579bd View commit details
    Browse the repository at this point in the history

Commits on Sep 20, 2024

  1. refactor: NotificationPresenter::Create() returns a std::unique_ptr<> (

    …#43806)
    
    Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
    Co-authored-by: Charles Kerr <charles@charleskerr.com>
    trop[bot] and ckerr authored Sep 20, 2024
    Configuration menu
    Copy the full SHA
    2bc8797 View commit details
    Browse the repository at this point in the history
  2. fix: third time screen sharing on macOS (#43809)

    Because we used decrementing negative source ids for fake video id when
    instantating a native macOS screen share picker, we eventually hit the
    `DesktopMediaID::kFakeId = -3` in Chromium source code which displayed a
    test green screen.
    
    In this change we reserve our own fake id of `-4` and decrement the
    window id integer for uniqueness instead.
    
    Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
    Co-authored-by: Fedor Indutny <238531+indutny@users.noreply.github.com>
    trop[bot] and indutny authored Sep 20, 2024
    Configuration menu
    Copy the full SHA
    8ac9d16 View commit details
    Browse the repository at this point in the history
Loading