Skip to content

Revert "Add support for Kibana knowledge base entry assets (#807)"#813

Merged
jsoriano merged 3 commits intoelastic:mainfrom
pgayvallet:kbn-xxx-revert-kb-spec
Oct 10, 2024
Merged

Revert "Add support for Kibana knowledge base entry assets (#807)"#813
jsoriano merged 3 commits intoelastic:mainfrom
pgayvallet:kbn-xxx-revert-kb-spec

Conversation

@pgayvallet
Copy link
Copy Markdown
Contributor

What does this PR do?

Reverts #807

@pgayvallet pgayvallet marked this pull request as ready for review October 9, 2024 11:31
@pgayvallet pgayvallet requested a review from a team as a code owner October 9, 2024 11:31
Copy link
Copy Markdown
Member

@jsoriano jsoriano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for preparing the revert!

Comment on lines -13 to -15
- description: Add support for semantic_text field definition
type: enhancement
link: https://github.com/elastic/package-spec/pull/807
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This entry should stay, right?

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pushed a commit to recover this entry. Will auto-merge if CI passes.

@jsoriano jsoriano enabled auto-merge (squash) October 10, 2024 17:33
@jsoriano jsoriano disabled auto-merge October 10, 2024 17:33
@jsoriano jsoriano enabled auto-merge (squash) October 10, 2024 17:33
@jsoriano jsoriano merged commit 3afde74 into elastic:main Oct 10, 2024
@elasticmachine
Copy link
Copy Markdown

💚 Build Succeeded

History

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants