Add validation to check if time series data streams have dimensions#655
Merged
jsoriano merged 2 commits intoelastic:mainfrom Nov 1, 2023
Merged
Add validation to check if time series data streams have dimensions#655jsoriano merged 2 commits intoelastic:mainfrom
jsoriano merged 2 commits intoelastic:mainfrom
Conversation
mrodm
previously approved these changes
Oct 31, 2023
code/go/internal/validator/semantic/validate_dimensions_present.go
Outdated
Show resolved
Hide resolved
💚 Build Succeeded
History
cc @jsoriano |
Member
Author
|
test integrations |
|
Created or updated PR in integrations repostiory to test this vesrion. Check elastic/integrations#8357 |
Member
Author
|
Failures in elastic/integrations#8357 probably related to environment and not to this change. Tested validation in all packages locally and they pass, I will merge this change. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Add a validation to check that data streams with time series enabled have at least a dimension.
Why is it important?
These data streams are invalid, and rejected by Elasticsearch, detect the issue earlier.
See #458.
Checklist
test/packagesthat prove my change is effective.spec/changelog.yml.Related issues