Review tear down test system handlers#2252
Merged
mrodm merged 3 commits intoelastic:mainfrom Dec 9, 2024
Merged
Conversation
Collaborator
💚 Build Succeeded
History
cc @mrodm |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR revisits the handlers run in the Tear Down test process for the system tests.
When using independent Elastic Agents for each test scenario, the following handlers can be skipped:
When using independent Elastic Agents, those agents are going to be removed/uninstalled at the end of the test, so there is no need to run those two handlers. There is a special case where it needs to be kept the reassignment of the policy when using the
--no-provisionflag in system tests.