Merged
Conversation
3718388 to
bddd6a1
Compare
jsoriano
reviewed
Oct 19, 2023
internal/stack/serverless.go
Outdated
Comment on lines
+139
to
+140
| fleetURL := config.Parameters[paramServerlessFleetURL] | ||
| if true { |
Member
There was a problem hiding this comment.
Something seems to be missing here 🙂
Suggested change
| fleetURL := config.Parameters[paramServerlessFleetURL] | |
| if true { | |
| fleetURL, found := config.Parameters[paramServerlessFleetURL] | |
| if !found { |
Contributor
Author
There was a problem hiding this comment.
Oh! It was already like that previously.
Thanks! I'll update it.
Collaborator
💚 Build Succeeded
History
cc @mrodm |
jsoriano
approved these changes
Oct 19, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR allows to delete project even if the local docker-compose project fails.
This could happen if the
elastic-package stack up --provider serverlessfails while it is being initialized the project.At that moment the local docker-compose project (local agents) has not been created. And it probably could not be connected to Kibana to create the golang struct client.
How to test
docker-composewould fail (there is nosnaphost.ymlcreated yet)Example of
elastic-package stack down -voutput (this command fails, exit code != 0):