[system testing][logstash] Fix duplicate event entries when running with logstash#1497
Merged
bhapas merged 1 commit intoelastic:mainfrom Oct 9, 2023
Merged
[system testing][logstash] Fix duplicate event entries when running with logstash#1497bhapas merged 1 commit intoelastic:mainfrom
bhapas merged 1 commit intoelastic:mainfrom
Conversation
Collaborator
💚 Build Succeeded
cc @bhapas |
jsoriano
approved these changes
Oct 9, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When the stack is pulled up with
logstashhavingelastic_integrationplugin , it does not pass on the_idof the document created when running ingest pipelines , leading to duplicate entries inelasticsearchThis PR solves the issue by setting the
document_idin elasticsearch output.How to test this duplication
test/packages/with-logstash/ti_mispelastic-package test system -v[ Without this PR , the test fails as there is a deliberate duplicate event added to the system tests ]