fix(mapstr): cast inner maps to M on Clone#283
Merged
mauri870 merged 1 commit intoelastic:mainfrom Feb 24, 2025
Merged
Conversation
This was referenced Feb 21, 2025
Collaborator
💚 Build Succeeded
cc @mauri870 |
leehinman
approved these changes
Feb 21, 2025
efd6
approved these changes
Feb 23, 2025
Contributor
efd6
left a comment
There was a problem hiding this comment.
I think this is unfortunate and a result of poorly constructed tests in libbeat/processors/add_cloud_metadata, but approving.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
PR #262 changed the Clone behavior to preserve the type of inner
map[string]interface{}instead of casting them to M. This PR reverts this behavior since we rely on inner maps being casted to M in beats. This was not tested before, that is why we only caught it now. Additionally, add tests to ensure this behavior is preserved.Checklist
Related issues