Skip to content

Update go mod and go sum to use the latest nodeAdm api#8677

Merged
kprahulraj merged 2 commits intoeksctl-io:mainfrom
prasad0896:updateNodeadm
Feb 19, 2026
Merged

Update go mod and go sum to use the latest nodeAdm api#8677
kprahulraj merged 2 commits intoeksctl-io:mainfrom
prasad0896:updateNodeadm

Conversation

@prasad0896
Copy link
Copy Markdown
Contributor

@prasad0896 prasad0896 commented Feb 14, 2026 •
edited
Loading

Description

Updated the go.mod and go.sum files to pull in the most recent nodeadm api from amazon-eks-ami repository.

This fixes #8621

Checklist

  • Added tests that cover your change (if possible)
  • Added/modified documentation as required (such as the README.md, or the userdocs directory)
  • [ x ] Manually tested
  • [ x ] Made sure the title of the PR is a good description that can go into the release notes
  • (Core team) Added labels for change area (e.g. area/nodegroup) and kind (e.g. kind/improvement)

BONUS POINTS checklist: complete for good vibes and maybe prizes?! 🤯

  • Backfilled missing tests for code in same general area 🎉
  • Refactored something and made the world a better place 🌟

Testing

Tested creation of managed nodegroup using the following yaml and validated that nodes were created successfully

apiVersion: eksctl.io/v1alpha5
kind: ClusterConfig

metadata:
  name: eks-arm-cluster
  region: us-west-2
  version: "1.34"

managedNodeGroups:
  - name: al2023-ng
    instanceType: m5.large
    minSize: 1
    desiredCapacity: 2
    maxSize: 3
    amiFamily: AmazonLinux2023
    # Override bootstrap command with nodeadm NodeConfig to set maxPodsExpression
    overrideBootstrapCommand: |
      ---
      apiVersion: node.eks.aws/v1alpha1
      kind: NodeConfig
      spec:
        kubelet:
          # Example: Reserve 1 ENI for custom networking (AWS VPC CNI Custom Networking feature)
          # This reduces available ENIs by 1 for pod networking
          maxPodsExpression: "((default_enis - 1) * (ips_per_eni - 1)) + 2"

Logs:

2026-02-13 17:28:14 [ℹ]  creating addon: vpc-cni
2026-02-13 17:28:14 [ℹ]  successfully created addon: vpc-cni
2026-02-13 17:28:14 [ℹ]  creating addon: kube-proxy
2026-02-13 17:28:15 [ℹ]  successfully created addon: kube-proxy
2026-02-13 17:28:15 [ℹ]  creating addon: coredns
2026-02-13 17:28:15 [ℹ]  successfully created addon: coredns
2026-02-13 17:30:16 [ℹ]  building managed nodegroup stack "eksctl-eks-arm-cluster-nodegroup-al2023-ng"
2026-02-13 17:30:16 [ℹ]  deploying stack "eksctl-eks-arm-cluster-nodegroup-al2023-ng"
2026-02-13 17:30:17 [ℹ]  waiting for CloudFormation stack "eksctl-eks-arm-cluster-nodegroup-al2023-ng"
2026-02-13 17:30:47 [ℹ]  waiting for CloudFormation stack "eksctl-eks-arm-cluster-nodegroup-al2023-ng"
2026-02-13 17:31:28 [ℹ]  waiting for CloudFormation stack "eksctl-eks-arm-cluster-nodegroup-al2023-ng"
2026-02-13 17:32:07 [ℹ]  waiting for CloudFormation stack "eksctl-eks-arm-cluster-nodegroup-al2023-ng"
2026-02-13 17:32:07 [ℹ]  waiting for the control plane to become ready
2026-02-13 17:32:08 [✔]  saved kubeconfig as "/Users/prshende/.kube/config"
2026-02-13 17:32:08 [ℹ]  no tasks
2026-02-13 17:32:08 [✔]  all EKS cluster resources for "eks-arm-cluster" have been created
2026-02-13 17:32:08 [ℹ]  nodegroup "al2023-ng" has 2 node(s)
2026-02-13 17:32:08 [ℹ]  node "ip-192-168-34-66.us-west-2.compute.internal" is ready
2026-02-13 17:32:08 [ℹ]  node "ip-192-168-81-204.us-west-2.compute.internal" is ready
2026-02-13 17:32:08 [ℹ]  waiting for at least 1 node(s) to become ready in "al2023-ng"
2026-02-13 17:32:08 [ℹ]  nodegroup "al2023-ng" has 2 node(s)
2026-02-13 17:32:08 [ℹ]  node "ip-192-168-34-66.us-west-2.compute.internal" is ready
2026-02-13 17:32:08 [ℹ]  node "ip-192-168-81-204.us-west-2.compute.internal" is ready
2026-02-13 17:32:08 [✔]  created 1 managed nodegroup(s) in cluster "eks-arm-cluster"
2026-02-13 17:32:08 [ℹ]  creating addon: metrics-server
2026-02-13 17:32:09 [ℹ]  successfully created addon: metrics-server
2026-02-13 17:32:10 [ℹ]  kubectl command should work with "/Users/prshende/.kube/config", try 'kubectl get nodes'
2026-02-13 17:32:10 [✔]  EKS cluster "eks-arm-cluster" in "us-west-2" region is ready

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Feb 14, 2026

Hello prasad0896 👋 Thank you for opening a Pull Request in eksctl project. The team will review the Pull Request and aim to respond within 1-10 business days. Meanwhile, please read about the Contribution and Code of Conduct guidelines here. You can find out more information about eksctl on our website

prasad0896
prasad0896 commented Feb 14, 2026
View reviewed changes
go.mod
github.com/aws/aws-sdk-go-v2/service/sts v1.41.6
github.com/aws/smithy-go v1.24.0
github.com/awslabs/amazon-eks-ami/nodeadm v0.0.0-20251001043626-89ce6578d960
github.com/awslabs/amazon-eks-ami/nodeadm v0.0.0-20260213141146-147b13ea3f4a
Copy link
Copy Markdown
Contributor Author

@prasad0896 prasad0896 Feb 14, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is the critical change, everything else is auto-updated.

@kprahulraj kprahulraj added the kind/feature New feature or request label Feb 16, 2026
@kprahulraj kprahulraj self-assigned this Feb 16, 2026
@kprahulraj
Copy link
Copy Markdown
Collaborator

kprahulraj commented Feb 16, 2026

Need to fix the unit test in al2023 with the bump in nodeadm dependency and the new flag

kprahulraj
kprahulraj approved these changes Feb 19, 2026
View reviewed changes
Copy link
Copy Markdown
Collaborator

@kprahulraj kprahulraj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified the change and tested. Good to merge

@kprahulraj kprahulraj merged commit 5361834 into eksctl-io:main Feb 19, 2026
8 checks passed
@eksctl-bot eksctl-bot mentioned this pull request Feb 19, 2026
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kprahulraj kprahulraj kprahulraj approved these changes

+1 more reviewer

@shvbsle shvbsle shvbsle approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@kprahulraj kprahulraj

Labels

kind/feature New feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Feature] Support for new args for nodeadm

3 participants

@prasad0896 @kprahulraj @shvbsle