fix integration test with eks default version change#8665
Merged
kprahulraj merged 1 commit intoeksctl-io:mainfrom Feb 5, 2026
Merged
fix integration test with eks default version change#8665kprahulraj merged 1 commit intoeksctl-io:mainfrom
kprahulraj merged 1 commit intoeksctl-io:mainfrom
Conversation
Contributor
|
Hello kprahulraj 👋 Thank you for opening a Pull Request in |
|
/lgtm |
sapphirew
reviewed
Feb 5, 2026
|
|
||
| // retrieve AL2 AMI | ||
| input := &awsssm.GetParameterInput{ | ||
| Name: aws.String(fmt.Sprintf("/aws/service/eks/optimized-ami/%s/amazon-linux-2/recommended/image_id", params.Version)), |
Contributor
There was a problem hiding this comment.
probably can add a TODO comment to deprecate this test for AL2 by 2026-06-30
sapphirew
approved these changes
Feb 5, 2026
Contributor
sapphirew
left a comment
There was a problem hiding this comment.
LGTM despite one minor comment
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
fix integration test with eks default version change
We recently changed the default version for eks to 1.34 for eksctl with ace3ad1. Although AL2 amis are not supported from 1.33 eks version so integration tests are failing
Fixing integration test to use 1.32 version for AL2 amis and other self ngs
Checklist
README.md, or theuserdocsdirectory)area/nodegroup) and kind (e.g.kind/improvement)BONUS POINTS checklist: complete for good vibes and maybe prizes?! 🤯