Skip to content

only create iam role stack for capability if the roleArn is not provided#8655

Merged
kprahulraj merged 1 commit intoeksctl-io:mainfrom
kprahulraj:main
Jan 26, 2026
Merged

only create iam role stack for capability if the roleArn is not provided#8655
kprahulraj merged 1 commit intoeksctl-io:mainfrom
kprahulraj:main

Conversation

@kprahulraj
Copy link
Copy Markdown
Collaborator

@kprahulraj kprahulraj commented Jan 25, 2026

Description

Issue #8654

Create iam role stack for capability to create the role only if the role is not provided through the flag --role-arn

Tests

Manually tested by providing the and without providing the role in the configuration and as flag --role-arn. The iam role-arn stack is only created and set if the flag is not provided. If the role-arn is provided by the customer wither through configuration or through flag, this is not created and customer provided role is used

Checklist

  • Added tests that cover your change (if possible)
  • Added/modified documentation as required (such as the README.md, or the userdocs directory)
  • Manually tested
  • Made sure the title of the PR is a good description that can go into the release notes
  • (Core team) Added labels for change area (e.g. area/nodegroup) and kind (e.g. kind/improvement)

BONUS POINTS checklist: complete for good vibes and maybe prizes?! 🤯

  • Backfilled missing tests for code in same general area 🎉
  • Refactored something and made the world a better place 🌟

@github-actions
Copy link
Copy Markdown
Contributor

Hello kprahulraj 👋 Thank you for opening a Pull Request in eksctl project. The team will review the Pull Request and aim to respond within 1-10 business days. Meanwhile, please read about the Contribution and Code of Conduct guidelines here. You can find out more information about eksctl on our website

@kprahulraj kprahulraj merged commit e6f98c3 into eksctl-io:main Jan 26, 2026
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants