Skip to content

Allow wildcard matching of service account subject#8629

Merged
NicholasBlaskey merged 3 commits intoeksctl-io:mainfrom
avoidik:feature/add-wildcard-sub
Jan 5, 2026
Merged

Allow wildcard matching of service account subject#8629
NicholasBlaskey merged 3 commits intoeksctl-io:mainfrom
avoidik:feature/add-wildcard-sub

Conversation

@avoidik
Copy link
Copy Markdown
Contributor

@avoidik avoidik commented Dec 12, 2025 •
edited
Loading

Description

This PR adds --subject-pattern to eksctl create iamserviceaccount.

#8628

Checklist

  • Added tests that cover your change (if possible)
  • Added/modified documentation as required (such as the README.md, or the userdocs directory)
  • Manually tested
  • Made sure the title of the PR is a good description that can go into the release notes
  • (Core team) Added labels for change area (e.g. area/nodegroup) and kind (e.g. kind/improvement)

BONUS POINTS checklist: complete for good vibes and maybe prizes?! 🤯

  • Backfilled missing tests for code in same general area 🎉
  • Refactored something and made the world a better place 🌟

@avoidik
Copy link
Copy Markdown
Contributor Author

avoidik commented Dec 12, 2025

Example:

eksctl create iamserviceaccount \
    --name crossplane \
    --namespace crossplane-system \
    --cluster "$CLUSTER_NAME" \
    --role-name "$ROLE_NAME" \
    --attach-policy-arn 'arn:aws:iam::aws:policy/AdministratorAccess' \
    --subject-pattern 'provider-aws-*' \
    --role-only \
    --approve

@avoidik avoidik changed the title Allow wildcard matching for service account subject Allow wildcard matching of service account subject Dec 12, 2025
@avoidik avoidik mentioned this pull request Dec 12, 2025
Closed
NicholasBlaskey
NicholasBlaskey reviewed Dec 12, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@NicholasBlaskey NicholasBlaskey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Feature looks reasonable to me. Thanks for contributing a fix

Implementation looks good to me just have a comment couples

@NicholasBlaskey NicholasBlaskey added the kind/feature New feature or request label Dec 15, 2025
@avoidik avoidik force-pushed the feature/add-wildcard-sub branch from 5a85c17 to 8856e00 Compare January 4, 2026 12:09
@avoidik avoidik force-pushed the feature/add-wildcard-sub branch from 8856e00 to 6eaa20b Compare January 4, 2026 12:10
@avoidik
Copy link
Copy Markdown
Contributor Author

avoidik commented Jan 4, 2026

@NicholasBlaskey I've regenerated the schema, I believe my PR is now ready, please have a look

NicholasBlaskey
NicholasBlaskey approved these changes Jan 5, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@NicholasBlaskey NicholasBlaskey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for contributing

@NicholasBlaskey NicholasBlaskey merged commit d965e8e into eksctl-io:main Jan 5, 2026
8 checks passed
@eksctl-bot eksctl-bot mentioned this pull request Jan 5, 2026
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@NicholasBlaskey NicholasBlaskey NicholasBlaskey approved these changes

Assignees

No one assigned

Labels

kind/feature New feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@avoidik @NicholasBlaskey