issue-628 Handled failures which might occur during write-behind#3127
Merged
chrisdennis merged 1 commit intoehcache:masterfrom May 18, 2023
Merged
issue-628 Handled failures which might occur during write-behind#3127chrisdennis merged 1 commit intoehcache:masterfrom
chrisdennis merged 1 commit intoehcache:masterfrom
Conversation
Member
|
Failing tests need investigated |
chrisdennis
requested changes
Feb 10, 2023
Member
chrisdennis
left a comment
There was a problem hiding this comment.
This needs test coverage to prove it all works. Doing that should also expose some of the existing issues that need fixing.
...ava/org/ehcache/clustered/client/internal/loaderwriter/writebehind/ClusteredWriteBehind.java
Outdated
Show resolved
Hide resolved
...org/ehcache/clustered/client/internal/loaderwriter/writebehind/ClusteredWriteBehindTest.java
Outdated
Show resolved
Hide resolved
ehcache-api/src/main/java/org/ehcache/spi/loaderwriter/CacheLoaderWriter.java
Outdated
Show resolved
Hide resolved
...va/org/ehcache/impl/internal/loaderwriter/writebehind/BatchingLocalHeapWriteBehindQueue.java
Outdated
Show resolved
Hide resolved
...va/org/ehcache/impl/internal/loaderwriter/writebehind/BatchingLocalHeapWriteBehindQueue.java
Outdated
Show resolved
Hide resolved
...org/ehcache/impl/internal/loaderwriter/writebehind/NonBatchingLocalHeapWriteBehindQueue.java
Outdated
Show resolved
Hide resolved
...org/ehcache/impl/internal/loaderwriter/writebehind/NonBatchingLocalHeapWriteBehindQueue.java
Show resolved
Hide resolved
.../main/java/org/ehcache/impl/internal/loaderwriter/writebehind/operations/WriteOperation.java
Outdated
Show resolved
Hide resolved
.../java/org/ehcache/impl/internal/loaderwriter/writebehind/WriteBehindProviderFactoryTest.java
Outdated
Show resolved
Hide resolved
chrisdennis
requested changes
Mar 1, 2023
Member
chrisdennis
left a comment
There was a problem hiding this comment.
We still need test coverage here to show that the correct clean up is happening.
...va/org/ehcache/impl/internal/loaderwriter/writebehind/BatchingLocalHeapWriteBehindQueue.java
Outdated
Show resolved
Hide resolved
...va/org/ehcache/impl/internal/loaderwriter/writebehind/BatchingLocalHeapWriteBehindQueue.java
Outdated
Show resolved
Hide resolved
ehcache-api/src/main/java/org/ehcache/spi/loaderwriter/CacheLoaderWriter.java
Outdated
Show resolved
Hide resolved
...n/java/org/ehcache/impl/internal/loaderwriter/writebehind/operations/DeleteAllOperation.java
Outdated
Show resolved
Hide resolved
Author
|
Since dead lock was happening in earlier solution for batching write-behind, changed to place to run the cleanup for failures. |
chrisdennis
requested changes
Mar 16, 2023
Member
chrisdennis
left a comment
There was a problem hiding this comment.
The tests here are still failing, but they do it sporadically. You should go look at the AbstractWriteBehind class and the implications of the implementation of that class and the order in which the cache and the latest map held in both of the concrete write behind implementation are cleaned up.
chrisdennis
requested changes
Apr 14, 2023
...org/ehcache/impl/internal/loaderwriter/writebehind/NonBatchingLocalHeapWriteBehindQueue.java
Outdated
Show resolved
Hide resolved
...va/org/ehcache/impl/internal/loaderwriter/writebehind/BatchingLocalHeapWriteBehindQueue.java
Outdated
Show resolved
Hide resolved
chrisdennis
requested changes
May 8, 2023
ehcache-api/src/main/java/org/ehcache/spi/loaderwriter/CacheLoaderWriter.java
Outdated
Show resolved
Hide resolved
chrisdennis
requested changes
May 15, 2023
Member
chrisdennis
left a comment
There was a problem hiding this comment.
This needs rebasing against latest HEAD of main and the subsequent commits should probably be squashed to form a more compact and logical commit stream (potentially down to a single commit).
…ng write-behind for issue#628
4f83bcd to
6f38cbd
Compare
Author
|
Re-based with master |
chrisdennis
approved these changes
May 18, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Handle the failure which may occur during following write-behind scenarios and removed failed entries from cache.