Skip to content

Tidy up#236

Merged
cstamas merged 8 commits intomainfrom
tidy-up
Feb 6, 2026
Merged

Tidy up#236
cstamas merged 8 commits intomainfrom
tidy-up

Conversation

@cstamas
Copy link
Copy Markdown
Member

@cstamas cstamas commented Feb 6, 2026

Changes:

  • share guice version as property
  • up Maven deps to latest 3.9.12
  • junit and testng rolled back to their original versions

Changes:
* rollback TestNG update; we don't use it as transitive dep
* share guice version as property
* up Maven deps to latest 3.9.12
@cstamas cstamas added this to the 1.0.0 milestone Feb 6, 2026
@cstamas cstamas requested a review from kwin February 6, 2026 16:34
@cstamas cstamas self-assigned this Feb 6, 2026
@cstamas cstamas added the dependencies Pull requests that update a dependency file label Feb 6, 2026
Comment thread pom.xml
<!-- Versions -->
<mavenRuntimeVersion>3.3.1</mavenRuntimeVersion>
<mavenBuildVersion>3.9.9</mavenBuildVersion>
<mavenBuildVersion>3.9.12</mavenBuildVersion>
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe just delete the Maven version there as we enforce it anyways.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@cstamas cstamas marked this pull request as ready for review February 6, 2026 16:44
@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud Bot commented Feb 6, 2026

@cstamas cstamas requested a review from kwin February 6, 2026 16:51
@cstamas cstamas merged commit 5aa4e7d into main Feb 6, 2026
14 checks passed
@cstamas cstamas deleted the tidy-up branch February 6, 2026 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants