Add child_api_host to AccountAdmin tests to fix failing tests#250
Merged
AaronAtDuo merged 1 commit intomasterfrom Feb 7, 2024
Merged
Add child_api_host to AccountAdmin tests to fix failing tests#250AaronAtDuo merged 1 commit intomasterfrom
AaronAtDuo merged 1 commit intomasterfrom
Conversation
AaronAtDuo
approved these changes
Feb 7, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
I don't know why this suddenly started failing, but during the AccountAdmin tests, it looks like AccountAdmin init is trying to really reach out to the API to fetch the child accounts. This pre-populates child_api_host so it doesn't make a request.
I don't know that this is necessarily the correct fix (e.g. vs ensuring that HTTP call is mocked), but it is a fix.
Motivation and Context
Fix the automated tests
How Has This Been Tested?
Tests now pass
Types of Changes